search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.01k stars 2.68k forks source link

Android Regression RN 0.73 - `onDropViewInstance` not called anymore, View not cleaned up #7852

Open bvonheid opened 4 months ago

bvonheid commented 4 months ago

What happened?

With the update to RN 0.73 the onDropViewInstance of ViewManager is not called anymore when a screen is popped from the stack. As stated here for the onDropViewInstance:

Called when view is detached from view hierarchy and allows for some additional cleanup by the ViewManager subclass.

What was the expected behaviour?

onDropViewInstance should be called when a view is popped from the stack.

Was it tested on latest react-native-navigation?

Help us reproduce this issue!

You can reproduce the error in the playground app:

  1. Run 7.38.1 on Android
  2. Attach a Debugger to the App
  3. Set a Breakpoint in the com/facebook/react/uimanager/ViewManager.class file in the onDropViewInstance Method
  4. Click in Layout tab on Stack -> Push -> Pop
  5. => After the Pop onDropViewInstance should be called, but it isn't

With the same steps with 7.37.2 onDropViewInstance is called.

In what environment did this happen?

React Native Navigation version: - React Native version: 0.73 Has Fabric (React Native's new rendering system) enabled: no Node version: - Device model: - Android version: -

szaboa commented 3 days ago

any update?

szaboa commented 2 days ago

any workaround then?