wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.01k stars 2.68k forks source link

Rename Dictionary into RNNDictionary #7853

Closed lampapos closed 4 months ago

lampapos commented 4 months ago

Dictionary interface might create a name collision with Swift Dictionary. Such collision might lead to issues like this:

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Unacceptable type of value for attribute: property = "data"; desired type = Dictionary; given type = _TtGCs26_SwiftDeferredNSDictionarySSSS_$; value = {
    "app_type" = MEP;
    "application_bundle_id" = "[.../)";
    "application_installer_id" = "com.apple.dt.Xcode";
    "application_name" = Xxx;
    "application_version" = "999.999.999";
    "client_id" = "6033B0D3-8960-4C89-9B5F-0EF0A9FDA30F";
    country = UA;
    "device_platform" = "iPhone16,1|iOS|17.2";
    "external_app_id" = "b8186bd9-fcba-b77a-11e3-1c0d2e5a3501";
    "mep_analytics_sdk_version" = "1.1.1";
}.'