fix(iOS): avoid cutting-off text on bottom bar buttons on iPad.

wix / react-native-navigation

A complete native navigation solution for React Native

https://wix.github.io/react-native-navigation/

MIT License

13.04k stars 2.67k forks source link

fix(iOS): avoid cutting-off text on bottom bar buttons on iPad. #7863

Closed asafkorem closed 6 months ago

asafkorem commented 6 months ago

For some reason, this change resolves the issue in the attached snapshots.

When centered=YES, setting the text alignment to NSTextAlignmentCenter (see here) may incidentally cause the text layout engine to more effectively manage the available space. Doesn't seem like it affects anything in iPhones.

Overall, it seems like a bug in UIKit..

Before: Screenshot 2024-03-20 at 17 16 15

After: Screenshot 2024-03-20 at 18 10 10

asafkorem commented 6 months ago

Thanks @phuongwd for finding this patch https://github.com/wix/react-native-navigation/issues/7855#issuecomment-2009196262