wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

[iOS] Fabric renderer fix #7867

Closed TheLonelyAstronaut closed 7 months ago

TheLonelyAstronaut commented 7 months ago

After migration to RN73,RNNReactView now extends from RCTSurfaceHostingProxyRootView and uses new initWithBridge: implementation (with Fabric) with RCTFabricSurface instance. In initWithBridge: method, we call [super initWithSurface:surface sizeMeasureMode:sizeMeasureMode], but this method located in RCTSurfaceHostingView (parent for RCTSurfaceHostingProxyRootView) and does not call [surface start] (unlike RCTSurfaceHostingProxyRootView [super initWithSurface:surface] that calls it, but it does not allow us to specify RCTSurfaceSizeMeasureMode), so all we need to do is to call [surface start] after RNNReactView init.

Also I created Expo plugin for this wonderful library, it supports SDK 49 and SDK 50 (RN 72 & 73): RNN Expo Plugin

asafkorem commented 7 months ago

Released with 7.39.2 Thanks @TheLonelyAstronaut