"No package name found" - Githubissues

wix / react-native-navigation

A complete native navigation solution for React Native

https://wix.github.io/react-native-navigation/

MIT License

13.04k stars 2.67k forks source link

"No package name found" #7896

Open ejain opened 4 months ago

ejain commented 4 months ago

What happened?

After upgrading react-native-navigation from 7.39.2 to 7.40.1, builds with React Native 0.70.x (or older?) fail:

error Failed to build the app: No package name found. We couldn't parse the namespace from neither your build.gradle[.kts] file at node_modules/react-native-navigation/lib/android/app/build.gradle nor your package in the AndroidManifest at node_modules/react-native-navigation/lib/android/app/src/main/AndroidManifest.xml.

This breaking change appears to have been introduced in https://github.com/wix/react-native-navigation/commit/6439f6858110fe79b7f9260b91f84dfd6e0e904d.

What was the expected behaviour?

No response

Was it tested on latest react-native-navigation?

[X] I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

No response

In what environment did this happen?

React Native Navigation version: 7.40.1 React Native version: 0.70.15 Node version: 18.19.0

JB712 commented 4 months ago

Got something similar after app build with RNN 7.40.1 and RN 0.73.9 for every module that is not accessed by path (so every one that have a package.json in it's folder): Error: Unable to resolve module "module_name" [...] "module_name" could not be found within the project or in these directories