search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

test: add test for title undefined in merge options #7900

Closed Niryo closed 3 months ago

asafkorem commented 3 months ago

Issue comes from here: https://github.com/wix/react-native-navigation/blob/master/lib/Mock/Layouts/ParentNode.ts#L46-L48 We don't set the topbar title anywhere in this mock.. so it might come from there (this.data.options.topBar.title)

Niryo commented 3 months ago

looks like e2e tests fail as well, so maybe it actually works? I need to check it against production and see what happens. closing for now