Open siddarthkay opened 2 months ago
I found 2 new errors :
> Task :react-native-navigation:compileReactNative71DebugJavaWithJavac
/private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/react-native-navigation/lib/
android/app/src/main/java/com/reactnativenavigation/utils/ReactTypefaceUtils.java:99:
error: cannot find symbol
|| ((oldStyle & Typeface.BOLD) != 0 && weight == ReactTextShadowNode.UNSET)) {
^
symbol: variable UNSET
location: class ReactTextShadowNode
/private/tmp/nix-build-status-mobile-build-debug-android.drv-3/node_modules/react-native-navigation/lib/
android/app/src/main/java/com/reactnativenavigation/
utils/ReactTypefaceUtils.java:104: error: cannot find symbol
|| ((oldStyle & Typeface.ITALIC) != 0 && style == ReactTextShadowNode.UNSET)) {
^
symbol: variable UNSET
location: class ReactTextShadowNode
I've just tested it and got:
e: file:///Users/thomasfetiveau/wksp_olap/OlapRN75/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/LayoutDirectionApplier.kt:16:2 Missing '}
@zabojad : probably you missed a }
while applying this patch.
I could see builds passing here without any syntax errors -> https://github.com/status-im/status-mobile/pull/21268
hey @siddarthkay ! I've applyied the fix directly from this PR (I did not change any file manually before testing it). Also, when double checking the files of this PR, we see the missing '}' there:
Anyway... It's not a big deal, I just wanted to tell you so that you fix your PR...
in react-native-reanimated resolved like this as border Radius is not the same with fullBorderWidth
val ReactViewGroup.borderRadius: Float
get(){
val uniform: LengthPercentage = (background as? CSSBackgroundDrawable)?.borderRadius?.uniform
?: return 0f
return uniform.resolve(
width.toFloat(), height.toFloat()
)
}
Any chance this can get verified and merged? I've ran into this issue in a project I'm working on and am kind of blocked until this is resolved.
Summary
This PR fixes the following Kotlin build issues which were discovered after I upgraded
react-native
to0.75.3
andreact-native-navigation
to7.40.1
fixes: https://github.com/wix/react-native-navigation/issues/7905, https://github.com/wix/react-native-navigation/issues/7911