search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

fix(ios): ensure correct initial tab is rendered when onSwitchToTab is set #7922

Closed ismarbesic closed 1 month ago

ismarbesic commented 1 month ago

Fixes #7921 by setting _currentTabIndex in the RNNBottomTabsController before initialization happens.

_currentTabIndex needs to be set before the super() is called, since - [RNNBottomTabsController selectedViewController] will be called during initialization and which depends on _currentTabIndex. If not set, an initial render of the tab content with index 0 will occur when tabsAttachMode is set to "onSwitchToTab".

ismarbesic commented 1 month ago

hey @asafkorem! any chance you can help me out reviewing this PR?

asafkorem commented 1 month ago

Hey @ismarbesic, I'll review your PR soon. Thanks!

asafkorem commented 1 month ago

Released with v7.40.3