search

wix / react-native-notifications

React Native Notifications
MIT License
3.25k stars 764 forks source link

Separate local Notification Creation logic from Firebase #799

Closed SaeedZhiany closed 2 years ago

SaeedZhiany commented 2 years ago

first of all, Thanks for the amazing library.

Today, most developers use react-native-firebase to integrate firebase modules in their projects including the Cloud messaging module. Personally, I'm using this library just for creating local notifications because it gives me more control than other existing libraries (due to the ability to override and implement more features on the android side)

also using react-native-firebase and react-native-notifications together in one project make developers handle firebase mismatching.

I have two suggestions:

  1. completely remove firebase support from this library and encourage developers to use react-native-firebase as a more standard and well-maintained firebase solution for react-native and keeps the focus of this repository just on creating and customizing local notifications
  2. separate firebase-related logic from local notification management logic and publish them as two packages (using the new npm Monorepo feature) so developers can decide which firebase solution they want to use without struggling about resolving the conflicts between the RN firebase libraries.
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

DanielEliraz commented 2 years ago

Option 2 sounds better. I think it's not bad to have some packages that have the same goal. each of them can have it's own advantages and we can encourage each other to do better