search

wix / react-native-notifications

React Native Notifications
MIT License
3.25k stars 764 forks source link

.registerRemoteNotifications return type suggestion (void -> Promise<void>) #857

Closed passengerV closed 2 years ago

passengerV commented 2 years ago

Dear Contributors, First of all, thank you for your hard work. It makes my and other developers life much easier.

While using your library, I noticed that .registerRemoteNotifications method has no return value after execution (void). Would it be possible to improve it and to return a Promise after the execution is finished? It would be specially handy on iOS, since on first run user is prompted and the app logic can't rely on current void value - there is no indication when logic like navigation to next screen can happen. As a work-around, for now I will use react-native-permissions for prompting users, as it returns Promise.

Best regards, V.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 2 years ago

The issue has been closed for inactivity.