wix / react-native-notifications

React Native Notifications
MIT License
3.25k stars 765 forks source link

Typing of `postLocalNotification` is incorrect #875

Closed thomasttvo closed 2 years ago

thomasttvo commented 2 years ago

image

tomekpilat commented 2 years ago

I'm experiencing the same issue. @thomasttvo have you been able to resolve it?

thomasttvo commented 2 years ago

I switched to this lib https://notifee.app/, so much better on all fronts

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

edualm commented 2 years ago

Bad bot - it's still happening.

Tessaroo commented 2 years ago

issue is still present, documentation for this library has been a roller coaster

1mehdifaraji commented 2 years ago

@thomasttvo I did too and it is awesome just one question what version of xcode and iOS is ok with the latest version of notifee ?

camboYY commented 2 years ago

not work for android

jcarioti commented 2 years ago

I switched to this lib https://notifee.app/, so much better on all fronts

How did you handle the missing APNS registration that Notifee doesn't support? I tried to swap it out, but it only seems to support FCM.

chrisarts commented 2 years ago

I switched to this lib https://notifee.app/, so much better on all fronts

How did you handle the missing APNS registration that Notifee doesn't support? I tried to swap it out, but it only seems to support FCM.

thats right Im working with Azure notifications HUB and notifee combined with this lib does not fire notifications when you are using other apps.

Im trying to use just this lib and its working but the problem is that this lib wakes the entire app in background and sometimes iOS just kill the background fetch even if such process just take a few seconds.

jcarioti commented 2 years ago

We aren't doing any background fetch with Notifee, but it sounds like you're not calling the completion handlers in time?

We also landed on a hybrid approach of using this library with Notifee. RN Notifications is responsible for the remoteRegistration portion, and the foreground remote notification reception, and then we pipe everything through Notifee for the final notification. So all of our notifications come from Notifee besides the remote ones we don't currently intercept.

I really hope this gets cleaner soon, because it's really janky as-is. IMO, Notifee is the way to go if we had a clear/concise replacement for RN Notification's remote registration logic. We might just do it natively since it's not super complex.

chrisarts commented 2 years ago

This is my approach the onNotificationHandler is just in char of display the local notification based on the payload sent by Azure hub.

Unfurtanetly im not a native mobile dev, so I have to relay on this solutions for now.

Screen Shot 2022-10-07 at 7 12 01 PM

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 2 years ago

The issue has been closed for inactivity.

AloeareV commented 1 year ago

Issue is still present

kg-currenxie commented 1 year ago

Pls fix :|

josef256 commented 1 year ago

pretty sure this lib is "abandonware" i'll just move on to react-native-push-notification

kg-currenxie commented 1 year ago

pretty sure this lib is "abandonware" i'll just move on to react-native-push-notification

https://github.com/zo0r/react-native-push-notification ? its officially not maintained, and lastly updated Dec 2021

josef256 commented 1 year ago

pretty sure this lib is "abandonware" i'll just move on to react-native-push-notification

https://github.com/zo0r/react-native-push-notification ? its officially not maintained, and lastly updated Dec 2021

yeah i saw that.. it has also problem with react 0.71+ i tried https://github.com/invertase/notifee meanwhile and it works great out of the box plus it's actively maintained

kg-currenxie commented 1 year ago

i tried invertase/notifee meanwhile and it works great out of the box plus it's actively maintained

cool, good to know :) it wasn't free when we started implementing.. might switch then