wix / react-native-notifications

React Native Notifications
MIT License
3.25k stars 764 forks source link

Hey, in android 13 the notifications are shown, but they are not clickable #939

Closed giannis21 closed 1 year ago

giannis21 commented 1 year ago

In order for the notifications to be clickable i must enable the option 'display over other apps' . When the app is debug mode this choice exists in app settings, but when i run the app in release mode, this choice does not exist. Any help? Thanks in advance!

seco35 commented 1 year ago

Could you provide more information? Such as your rn and react-native-notifications version and on what device you'd observed this behaviour.

It works for me with rn 0.71.2 and react-native-notifications ^4.3.2 on Samsung Galaxy A13 (Android 13 - API 33).

b3itgustaf commented 1 year ago

I'm experiencing the same issue. Tapping a notification in the list of notifications, or on the lock screen, does nothing but discard the notification. I'm expecting the tap to open the application, as was the case with react-native-push-notifications-package.

Using: react-native: 0.71.1 react-native-notifications: 4.3.3

I've set up everything according to the guide here.

Could this have anything to do with setting up a service and intent-filter in the androidmanifest, like described here?

giannis21 commented 1 year ago

Guys in android 13 in some devices i need this permission in manifest (SYSTEM_ALERT_WINDOW) This sometimes can either work if the user enables the option 'display over the other apps' in settings or it justs works without enabling anything in settings. Anyway by adding this i made it work

b3itgustaf commented 1 year ago

@giannis21 you should not need to request that permission, I believe the issue lies in trampoline restrictions introduced in Android 12, described here. In our app we absolutely cannot break the UX-flow by directing the users to the app-settings to manually enable the display over other apps-setting.

There's a pending PR for fixing this issue, but the code owners doesn't seem to have had time reviewing it: https://github.com/wix/react-native-notifications/pull/920

ovbm commented 1 year ago

Guys in android 13 in some devices i need this permission in manifest (SYSTEM_ALERT_WINDOW) This sometimes can either work if the user enables the option 'display over the other apps' in settings or it justs works without enabling anything in settings. Anyway by adding this i made it work

Adding <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> to AndroidManifest.xml and manually allowing "Display over other apps" on the device is the only way I've been able to make notifications actually open our app on Android 13. I have no idea how these two are related, will investigate further. For reference I'm running react-native-notifications-: 4.3.3 with #920 applied with patch-packages.

Anyone else facing this issue?

arienemaiara commented 1 year ago

Hey guys, I was facing the same problem and I could get it fixed with https://github.com/zo0r/react-native-push-notification/pull/2352

ovbm commented 1 year ago

Thank you! Replacing implementation 'com.google.firebase:firebase-core:16.0.0' with implementation "com.google.firebase:firebase-messaging:23.1.2" in android/build.gradle did the trick.

firebase-core is deprecated. Should the android installation documentation be updated?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

The issue has been closed for inactivity.

katwal-dipak commented 7 months ago

Adding dependency implementation(platform("com.google.firebase:firebase-bom:32.8.0")) instead of implementation 'com.google.firebase:firebase-core:x.x.x' at android/build.gradle solved the issue in my case.