search

wix / react-native-notifications

React Native Notifications
MIT License
3.23k stars 763 forks source link

Trigger remoteNotificationsRegistrationFailed on Android when registerRemoteNotifications fails #949

Closed mb706 closed 1 year ago

mb706 commented 1 year ago

As I understand it, calling Notifications.registerRemoteNotifications() ends up calling FirebaseMessaging's getToken() eventually. A failure here (!task.isSuccessful()) seems to be ignored. Would it make sense to trigger the "remoteNotificationsRegistrationFailed" event here, so that the app can inform the user about problems through registerRemoteNotificationsRegistrationFailed?

I was playing around with Notifications and had some connectivity problems, and was surprised that neither callback registered with "registerRemoteNotificationsRegistered()" nor with "registerRemoteNotificationsRegistrationFailed()" were called.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

The issue has been closed for inactivity.

jkoutavas commented 1 year ago

Would like to see this question answered.

jorgegvallejo commented 1 year ago

This probably shouldn't be closed.