Closed C-Flatla closed 1 year ago
Shouldn't we be working on fixing the underlying (root) cause instead of sweeping the problem under the (logging) rug? 🤔
Despite the various problems this library has and the numerous hours I spent debugging (and still do) to get Android to handle notifications correctly in all states (dead/background/foreground), personally, I'm not very fond of the approach taken here.
Shouldn't we be working on fixing the underlying (root) cause instead of sweeping the problem under the (logging) rug? 🤔
Despite the various problems this library has and the numerous hours I spent debugging (and still do) to get Android to handle notifications correctly in all states (dead/background/foreground), personally, I'm not very fond of the approach taken here.
Of course, you're right but a crash is unacceptable
@DanielEliraz is there anything I need to do to get this merged in? I merged in latest master
so it was up to date 😄.
@C-Flatla Will be soon in production
What's in this PR?
This PR fixes a
NullPointerException
on Android when app is resumed by opening a notification.Why was this PR created?
This fixes issues:
951
910
Quick summary of the changes you made
mNotificationProps.asBundle()
intry/catch
to prevent app crashesAny necessary explanation of decisions you made
Picture of cat