wix / react-native-ui-lib

UI Components Library for React Native
https://wix.github.io/react-native-ui-lib/
MIT License
6.45k stars 706 forks source link

Not compatible with Expo 42? #1423

Closed ConnorLanglois closed 2 years ago

ConnorLanglois commented 3 years ago

Just getting started with Expo and React Native. Using Expo's latest version 42, the expo-cli installs react 16.13.1, but react-native-ui-lib has a peer dependency on react >=17.0.1, thus I am running into this issue when trying to install the package:

npm ERR! Found: react@16.13.1
...
npm ERR! Could not resolve dependency:
npm ERR! peer react@">=17.0.1" from react-native-ui-lib@5.27.0

Should I just force the installation or bump my react version and hope for the best?

Note: This issue is also present for the react-native dependency (0.63.4 vs. >=0.64.1).

softshipper commented 3 years ago

@ConnorLanglois I have installed react-native-ui-lib on my project based EXPO 42 and have received the following messages:

npm install react-native-ui-lib
npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 

added 35 packages, removed 770 packages, changed 35 packages, and audited 3536 packages in 3m

186 packages are looking for funding
  run `npm fund` for details

52 vulnerabilities (16 low, 14 moderate, 22 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

Maybe try to install react-native-ui-lib@5.28.0.

Best regards

kemalaydin commented 3 years ago

Expo 42 works with React Native version 0.63.3. RNUI works with at least 0.63.4 React Native version after 5.19 version.

So try this setup to use it with Expo 42. npm install react-native-ui-lib@^5.19.0

ethanshar commented 3 years ago

I just created a new project with latest expo and installed latest version of react-native-ui-lib and everything seem to work fine.

l2aelba commented 3 years ago

Any luck without downgrading to old react-native-ui-lib version?

Does not work for me

Any luck without downgrading to old react-native-ui-lib version?

ethanshar commented 3 years ago

I hope this will fix the issue

ethanshar commented 2 years ago

Please try our latest version (6.1.2). We recently fixed some issues. You can also try out our expo-snack demo app