Picker missing props - Githubissues

wix / react-native-ui-lib

UI Components Library for React Native

https://wix.github.io/react-native-ui-lib/

MIT License

6.44k stars 706 forks source link

Picker missing props #2250

Closed LazyAfternoons closed 1 year ago

LazyAfternoons commented 2 years ago

Description

Since the last version, TypeScript shows an error regarding the Picker component: Type '{ children: Element[]; migrateTextField: true; showSearch: boolean; value: selecteDate; onChange: (value: selecteDate) => void; placeholder: string; placeholderTextColor: string; fieldStyle: { ...; }; containerStyle: { ...; }; }' is missing the following properties from type 'Pick<any, "value" | "onChange" | "renderExpandableInput" | "renderExpandable" | "onToggleExpandableModal" | "topBarProps" | "rightButtonProps" | "color" | "containerStyle" | ... 436 more ... | "pickerModalProps">': renderExpandableInput, renderExpandable, onToggleExpandableModal, topBarProps, and 433 more.ts(2740)

Related to

[ ] Components
[ ] Demo
[ ] Docs
[x] Typings

Environment

React Native version: 0.69
React Native UI Lib version: 6.21.0

chrdevmar commented 2 years ago

also experiencing this, tried to solve by creating our own wrapped Picker which overrode types with Partial<originalProps> but was a pain. ended up downgrading react-native-ui-lib to 6.20.4 to solve typescript errors for now.

Environment (looks like you've got yours around the wrong way btw):

React Native UI Lib version: 6.21.0
React Native version: 0.69.5

LazyAfternoons commented 2 years ago

also experiencing this, tried to solve by creating our own wrapped Picker which overrode types with Partial<originalProps> but was a pain. ended up downgrading react-native-ui-lib to 6.20.4 to solve typescript errors for now.

Environment (looks like you've got yours around the wrong way btw):

React Native UI Lib version: 6.21.0

React Native version: 0.69.5

Thank you for confirming this issue. Environment fixed, thanks.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MiguelAraCo commented 1 year ago

Also experiencing this. The latest version (6.23.0) doesn't seem to fix the issue.

The-White-Fang commented 1 year ago

6.23.1 seems broken as well. In my case I am seeing Dialog infered as const Dialog: React.ComponentClass<any, any> & typeof Dialog. Is there a quick fix for it?