wix / react-native-ui-lib

UI Components Library for React Native
https://wix.github.io/react-native-ui-lib/
MIT License
6.44k stars 706 forks source link

Modal and Dialog not rendering with transparent background when default background color for `View` is set by `ThemeManager` #2352

Closed The-White-Fang closed 1 year ago

The-White-Fang commented 1 year ago

Description

If you use ThemeManager to set the default backgroundColor for your View, the transparent Modal background color changes to opaque. The issue is that these components are using View components that have been modified using theme manager.

Related to

Steps to reproduce

Use theme manager to set the detault theme for View component

ThemeManager.setComponentTheme('View', (props: { [key: string]: any }) => ({
    backgroundColor: Colors.bgColor,
}));

and now try to render the DIalog example or Modal example.

Expected behavior

The modal should render with transparent background.

Actual behavior

The modal is rendered with solid background

More Info

Code snippet

Screenshots/Video

Environment

Affected platforms

phuocantd commented 1 year ago

maybe you using style props

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.