search

wix / react-native-ui-lib

UI Components Library for React Native
https://wix.github.io/react-native-ui-lib/
MIT License
6.44k stars 706 forks source link

Missing types on Drawer and Text components #2511

Closed nizans closed 1 year ago

nizans commented 1 year ago

Description

Missing types for Drawer and Text components.

Related to

Steps to reproduce

npm install the library, for me it produced on 7.1.1 Import Drawer or Text component either as named import or as a package import Write the component as JSX Types are missing,

Expected behavior

Should have full type safety and autocomplete like the rest of the components

Actual behavior

Missing types

More Info

Version 7.1.1 Reproduced on different workspaced.

Code snippet

import React from "react";
import { Drawer, Avatar, Text } from "react-native-ui-lib";

const App = () => {
  return (
    <Drawer iCanPutAnythingHere="foo">
      <Text andHereAlso="bar"> Missing Type safety!</Text>

      {/* Type safety! */}
      <Avatar size={1} butNotHere="!"/>
    </Drawer>
  );
};

export default App;

Screenshots/Video

image (1)

image (2)

image

Environment

Affected platforms

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.