TextField - add margin btw bottom elements and char counter

wix / react-native-ui-lib

UI Components Library for React Native

https://wix.github.io/react-native-ui-lib/

MIT License

6.46k stars 707 forks source link

TextField - add margin btw bottom elements and char counter #3185

Closed Inbal-Tish closed 2 months ago

Inbal-Tish commented 2 months ago

Description

TextField - add margin btw bottom elements and char counter, adding tests to validationMessage change

Will need to update private snapshot tests after merge

Changelog

TextField - add margin btw bottom elements and char counter, adding tests to validationMessage change

Additional info

adids1221 commented 2 months ago

@Inbal-Tish any related ticket ? Why do we add the margin ?

The code looks good, I'm just not sure where the margin is coming from.

Inbal-Tish commented 2 months ago

@Inbal-Tish any related ticket ? Why do we add the margin ?

The code looks good, I'm just not sure where the margin is coming from.

We need the margin since it's defined in the guidelines and so the validationMassage / helperTest won't stick to the charCounter - I fixed the condition to reflect that. Thanks