search

wix / react-native-ui-lib

UI Components Library for React Native
https://wix.github.io/react-native-ui-lib/
MIT License
6.59k stars 717 forks source link

Incubator.Dialog - Fixed content component being created on every render. #3231

Closed nitzanyiz closed 3 months ago

nitzanyiz commented 3 months ago

Description

The new useDialogContent hook was creating a component (DialogContent) on every render and then rendering it. This component is a "new" component every time therefore causing the component to render nonstop. This could also be solved using useMemo but I don't see any use to it since DialogContent has no state.

Changelog

Incubator.Dialog - Fixed content renders.

Additional info

MADS-4444