wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

text on exitdialog needs to be separate from checkbox #1687

Open wixbot opened 16 years ago

wixbot commented 16 years ago

Following the steps in the Documentation page named "How To: Run the Installed Application After Setup" gives my installer a very unsightly grey box on the ExitDialog around the checkbox & text for running my app. See attached image for an easier explanation

I experienced this in WiX 2.0 when I was writing my own dialogs for the entire install process. I worked around it then by setting the height & width of the checkbox to the boundary of the checkbox & then using a text control for the text next to it. The reason for this is a checkbox control cannot be given the transparent attribute where as a text control can & thus you avoid the grey box problem as shown in the attached image.

bq. Originally opened by @pally_sandher@ from "http://sourceforge.net/p/wix/bugs/1284/":http://sourceforge.net/p/wix/bugs/1284/

wixbot commented 12 years ago

Originator: NO

The problem with the suggestion in this bug is that it prevents screen readers from begin able to associate the text with the check box and reduces the surface area needed to check the box. Both issues create serious accessibility problems and are not recommended for most applications.

If this recommendation is added to the documentation, a warning about the accessbility issues should be included as well.

wixbot commented 12 years ago

Originator: NO

Checkboxes lacking transparency is a Windows Installer limitation, so there's nothing WiX can do to fix it.

wixbot commented 12 years ago

Originator: NO

Any change here would break existing projects, so I'm moving this to v4.

wixbot commented 12 years ago

Originator: YES

Fair enough, didn't sound like it would be possible. If you guys agree to live with the status quo then close this ticket.

I'll likely drop that feature from my installer to keep the ladies in marketing happy as I've not got the spare time to re-write that dialog etc.

wixbot commented 12 years ago

Originator: YES

The perfect solution would be to modify the UI code so any Controls which can have text set can also be given the transparent attribute which would fix this for everyone everywhere. I don't know if this is possible though.

wixbot commented 12 years ago

Originator: YES

Substituting a different image for the final page only isn't possible without again re-writing my own version of the exit dialog which defeats the purpose. That image is the one used for "WixUIDialogBmp" which is present on the Welcome Dialog and many others. I've seen the workaround I described in the summary used on a few installers recently, most notably the 2008.1 P4V installer from Perforce (www.perforce.com) so I'm not the only person who runs into this issue.

I noticed the issue with the WiXUI_Minimal too when I was creating a plug-in installer but I had to insert a new dialog in the sequence anyway to so I ended up authoring a UI based on WiXUI_InstallDir but without the InstallDirDlg showing up as WiXUI_Minimal is pretty horrible anyway IMO.

wixbot commented 12 years ago

image of UI showing the bug

wixbot commented 12 years ago

Originator: NO

It might also be possible to workaround this by substituting a different image for the final page. The current image is the full size of the page, has a big red rectangle on the left and a big white rectangle on the right. You might be able to change that to be a big red rectangle on the left and a big transparent rectangle on the right. That should cause the whole right side of the page to appear gray instead of white with a gray cutout for the checkbox. You'd want to swap out the WixUIDialogBmp as described in wix.chm at WiX Help | Advanced WiX Topics | WixUI Dialog Library | Customizing the WixUI Dialog Sets. Caveat - I haven't tried this myself, I'm just thinking about it conceptually and it seems like this could be an option.

Also, note that this gray cutout is an issue for the EULA checkbox on the WixUI_Minimal dialog set as well.

wixbot commented 12 years ago

Originator: NO

It also prevents & as a way of specifying shortcut keys. I think the current approach is the lesser of two evils but I'm open to a better solution.

wixbot commented 10 years ago

Doc how .wxl can override size and extent of controls

Originally posted by barnson Area changed from wixui to wixtoolset.org Release changed from future to v3.x