wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

HeatFile task does not support suid #2217

Closed wixbot closed 8 years ago

wixbot commented 15 years ago

HeatFile task does not support -suid.

WixTasks\heatfile.cs protected override string GenerateResponseFileCommands() { WixCommandLineBuilder commandLineBuilder = new WixCommandLineBuilder();

        commandLineBuilder.AppendSwitch(this.OperationName);
        commandLineBuilder.AppendSwitch(this.File);

        commandLineBuilder.AppendSwitchIfNotNull("-cg ", this.componentGroupName);
        commandLineBuilder.AppendSwitchIfNotNull("-dr ", this.directoryRefId);
        commandLineBuilder.AppendIfTrue("-scom", this.SuppressCom);
        commandLineBuilder.AppendIfTrue("-srd", this.suppressRootDirectory);
        commandLineBuilder.AppendIfTrue("-sreg", this.SuppressRegistry);
        commandLineBuilder.AppendSwitchIfNotNull("-template:", this.Template);

...

Originally opened by mberchtold from http://sourceforge.net/p/wix/bugs/1719/

wixbot commented 12 years ago

I don't understand. Isn't it something trivial to add? Add a new variable bool SuppressUniqueId;

add one line of code commandLineBuilder.AppendIfTrue("-suid", this.SuppressUniqueId);

and change the xsd?

Mat

wixbot commented 12 years ago

Yes, and it would reset the test pass going on this month so we wouldn't ship on time next month. We'll fix it in the next release.

wixbot commented 12 years ago

Not something we'd take for WiX v.30 right now. Maybe v3.5.

wixbot commented 12 years ago

This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).

wixbot commented 12 years ago

This is already implemented - you don't see it in HeatFile because it's in a parent class of HeatFile, HeatTask (see HeatTask.cs).

The property you want to set to true is called "SuppressUniqueIds".