search

wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

Unicode hyphen is not accepted as the start of an option on Wix 3.10 heat.exe #5183

Open earthengine opened 8 years ago

earthengine commented 8 years ago

I download and installed Wix 3.10 yesterday and found that this version no longer regards my "-srd" flag, and so always creates "Debug" or "Release" sub-folders when running Heat.exe.

I fixed this by adding the line to the filter xslt file:

  <xsl:template match="wix:Directory[@Name='Debug' or @Name='Release']">
      <xsl:apply-templates/>
   </xsl:template>

But ideally we should be able to use "-srd" option.

barnson commented 8 years ago

Works for me. What does your Heat.exe command line look like?

earthengine commented 8 years ago

Emmm... I tried that again, it seems to work again. As I didn't touch anything rather than the project settings to remove and add back the "-srd" option, it confused me. But this was reported by our team member so it is not just me to have this problem. Let us keep an eye on this.

earthengine commented 8 years ago

After further careful check on our git history, it seems that the old Wix (3.9 or earlier) heat.exe recognize the Unicode hyphen (U+2212) as the start of an option. But the 3.10 version does not.

Our original command line, was copied from some online blog and only made minimum changes for our project. However, nobody noticed there is a different hyphen (and it was the only one of all 10 hyphens in the command line).

Can you find the difference of the hyphens?

  –srd -o

:)

barnson commented 8 years ago

Nobody during triage was excited about the feature but we'd consider such a change if someone did the work and it wasn't too disruptive to the command-line parsing.

bsktcase commented 8 years ago

OMG! This is exactly the problem I was having. I'll bet my predecessor copied from the same blog. Whether it ever gets fixed or not, bless you for posting the question - I don't think I would have spotted that errant hyphen in a million years. :)