search

wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

Built-in dialogs should support Right-to-left #5418

Open dennisr35 opened 8 years ago

dennisr35 commented 8 years ago

The built-in dialogs seem to exist in left-to-right writing direction only, for example WixUI_Minimal. There already is a translation to Arabic and Hebrew (RTL languages). The built-in dialogs should have a right-to-left version, like WixUI_Minimal_RTL.

dennisr35 commented 8 years ago

I found out you need to set LeftScroll, RightToLeft, and RightAligned attributes for all controls. I did this by changing the Wix source code. Setting the attributes for dialogs has no effect, you need to set for controls. Still the EULA license text in WelcomeEulaDlg is shown left-aligned. The RightToLeft flag should mirror all controls, so that the bitmap is displayed on the right side.

dennisr35 commented 8 years ago

I was able to change the Wix source code, to mirror controls on the standard dialogs. (Wix_Minimal). I had to invert the banner bitmaps also.

The problem which remains is that EULA text (WelcomeEulaDlg/LicenseText) is not right-aligned. (solved also by right-aligning the RTF file)

barnson commented 8 years ago

It shouldn't be necessary to modify the WiX authoring; all the settings should be settable in the .wxl localization files. If not, that's a bug with .wxl support. http://www.joyofsetup.com/2012/07/14/localizing-more-than-strings-in-wix-v3-6/

rseanhall commented 8 years ago

We don't have much RTL experience, but Bob will try with English to make sure the wxl supports it.

phillHgl commented 7 years ago

Thanks for the meeting recording. I have friends who can advise on Hebrew, although I have not used wix_UI in my projects. I have one WixStdBA project. How involved does a test project need to be (so I have some scope to pitch to them if you want me to ask if they would help. I don't know if they have the inclination.)

barnson commented 7 years ago

This issue is about MSI UI. WixStdBA and ThmUtil probably need more work to support RTL; not sure because I haven't done it before...

holonsphere commented 3 years ago

what sort of solutions are outside the scope of the project here?

barnson commented 3 years ago

@holonsphere : Please clarify your question.