search

wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

HarvestDirectory ItemGroup in the project works only on rebuild or clean build. #5877

Open skalinkin opened 5 years ago

skalinkin commented 5 years ago

We are pooling binaries from Artifactory to SourceDir\$(Configuration) folder. After the first build of .wixproj project the MSI is created with harvested files. On the next build with new binaries in the folder generation of the MSI is skipped with following reasons:

2>HarvestDirectory: Skipping target "HarvestDirectory" because all output files are up-to-date with respect to the input files. Compile: Skipping target "Compile" because all output files are up-to-date with respect to the input files. Link: Skipping target "Link" because all output files are up-to-date with respect to the input files.

<ItemGroup>
    <HarvestDirectory Include="SourceDir\$(Configuration)">
      <PreprocessorVariable>var.HarvestPath</PreprocessorVariable>
      <DirectoryRefId>INSTALLFOLDER</DirectoryRefId>
      <ComponentGroupName>HeatGenerated</ComponentGroupName>
      <SuppressRootDirectory>true</SuppressRootDirectory>
      <SuppressCom>true</SuppressCom>
      <SuppressRegistry>true</SuppressRegistry>
    </HarvestDirectory>
  </ItemGroup>

Please provide answers to the following questions to help us narrow down, reproduce, and fix the problem. Fill out one section and delete the others.

Bugs

If this issue is a bug:

(3.11.1.2318)

(Microsoft Visual Studio Professional 2017 Version 15.8.1 VisualStudio.15.Release/15.8.1+28010.2003 Microsoft .NET Framework Version 4.6.01586

Installed Version: Professional

Visual C++ 2017 00369-60000-00001-AA137 Microsoft Visual C++ 2017

AnkhSVN - Subversion Support for Visual Studio 2.7.12815.35086 AnkhSVN - Subversion Support for Visual Studio 2.7.12815.35086

SharpSvn is linked to: Apr 1.5.2, Apr-util 1.5.4, Cyrus Sasl 2.1.26, eXpat 2.2.0, LibSSH2 1.8.0, OpenSSL 1.0.2k 26 Jan 2017, Serf 1.3.9, SQLite 3.17.0, Subversion 1.9.5-SharpSvn, Utf8proc 1.1.5, ZLib 1.2.8 SharpSvn is optionally linked to: Berkeley DB 4.4.20, SharpPlink 0.67.0(SharpSvn)

SharpGit is linked to: Apr 1.5.1, Apr-Util 1.5.4, eXpat 2.1.0, Libgit2 0.24.0, LibSSH2 1.7.0, OpenSSL 1.0.2h 3 May 2016, Subversion 1.9.3, Utf8proc 1.1.5, ZLib 1.2.8

Application Insights Tools for Visual Studio Package 8.13.10627.1 Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2017 15.8.05074.0 ASP.NET and Web Tools 2017

ASP.NET Core Razor Language Services 15.8.31590 Provides languages services for ASP.NET Core Razor.

ASP.NET Web Frameworks and Tools 2017 5.2.60618.0 For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0 15.8.05023.0 Azure App Service Tools v3.0.0

Azure Data Lake Node 1.0 This package contains the Data Lake integration nodes for Server Explorer.

Azure Data Lake Tools for Visual Studio 2.3.3000.2 Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools 15.8.05023.0 Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio 2.3.3000.2 Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools 2.9.0-beta8-63208-01 C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Cookiecutter 15.8.18201.1 Provides tools for finding, instantiating and customizing templates in cookiecutter format.

Fabric.DiagnosticEvents 1.0 Fabric Diagnostic Events

JavaScript Language Service 2.0 JavaScript Language Service

JavaScript Project System 2.0 JavaScript Project System

JetBrains ReSharper Ultimate 2018.2.1 Build 182.0.20180829.63240 JetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2018 JetBrains, Inc.

Microsoft Azure HDInsight Azure Node 2.3.3000.2 HDInsight Node under Azure Node

Microsoft Azure Hive Query Language Service 2.3.3000.2 Language service for Hive query

Microsoft Azure Service Fabric Tools for Visual Studio 2.3 Microsoft Azure Service Fabric Tools for Visual Studio

Microsoft Azure Stream Analytics Language Service 2.3.3000.2 Language service for Azure Stream Analytics

Microsoft Azure Stream Analytics Node 1.0 Azure Stream Analytics Node under Azure Node

Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 2017 - v2.9.10730.2

Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of continuous build integration and continuous build delivery from within the Visual Studio IDE.

Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager 1.0 Install client-side libraries easily to any web project

Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers 1.1 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package

MLGen Package Extension 1.0 MLGen Package Visual Studio Extension Detailed Info

Node.js Tools 1.4.20802.1 Commit Hash:97e1085d8b4b8e3e51c398e910177f87e86d135e Adds support for developing and debugging Node.js apps in Visual Studio

NuGet Package Manager 4.6.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

Office Developer Tools for Visual Studio 2017 ENU 15.0.27907.01 Microsoft Office Developer Tools for Visual Studio 2017 ENU

ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info

Python 15.8.18201.1 Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.

Python - Django support 15.8.18201.1 Provides templates and integration for the Django web framework.

Python - IronPython support 15.8.18201.1 Provides templates and integration for IronPython-based projects.

Python - Profiling support 15.8.18201.1 Profiling support for Python projects.

R Tools for Visual Studio 1.3.40517.1016 Provides project system, R Interactive window, plotting, and more for the R programming language.

ResourcePackage Extension 1.0 ResourcePackage Visual Studio Extension Detailed Info

ResourcePackage Extension 1.0 ResourcePackage Visual Studio Extension Detailed Info

SQL Server Data Tools 15.1.61808.07020 Microsoft SQL Server Data Tools

Test Adapter for Boost.Test 1.0 Enables Visual Studio's testing tools with unit tests written for Boost.Test. The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test 1.0 Enables Visual Studio's testing tools with unit tests written for Google Test. The use terms and Third Party Notices are available in the extension installation directory.

ToolWindowHostedEditor 1.0 Hosting json editor into a tool window

TypeScript Tools 15.8.20801.2001 TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools 2.9.0-beta8-63208-01 Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools 10.2 for F# 4.5 15.8.0.0. Commit Hash: c55dd2c3d618eb93a8d16e503947342b1fa93556. Microsoft Visual F# Tools 10.2 for F# 4.5

Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Tools for CMake 1.0 Visual Studio Tools for CMake

Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers

Visual Studio Tools for Universal Windows Apps 15.0.28010.00 The Visual Studio Tools for Universal Windows apps allow you to build a single universal app experience that can reach every device running Windows 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 Software Development Kit.

VsVim 2.5.0.0 VsVim is a Vim emulator for Visual Studio

WiX Toolset Visual Studio Extension 0.9.21.62588 WiX Toolset Visual Studio Extension version 0.9.21.62588 Copyright (c) .NET Foundation and contributors. All rights reserved.

Workflow Manager Tools 1.0 1.0 This package contains the necessary Visual Studio integration components for Workflow Manager.)

(0.9.21.62588)

(4.6.1)

(The target HarvestDirectory is skipped. log in the build says: Skipping target "HarvestDirectory" because all output files are up-to-date with respect to the input files. I assume that there is no detection on files in side of the directory. It is true that directory was not changed even after removing it and creating)

(I expect Target will be executed when files in harvest directory are updated, removed or new files are added)

barnson commented 5 years ago

Please provide the data requested in the issue item template.

dvorn commented 5 years ago

This does not seem to be a bug really.

For the HarvestDirectory target, the inputs are all files in the folder been harvested, and the output is the generated wxs file. Thus, the target will be executed only when there is a file in the folder which is newer than the wxs file.

When you pull the files from the Artifactory, they probably are old files. But hey, you are already abusing the build system - those files are probably older than the sources from which they were created.

As a workaround, you can "touch" all or any of the files you pulled from the Artifactory to update their timestamps.

crusader-mike commented 2 years ago

FYI: deleting a file in harvested directory causes LGHT0103 : The system cannot find the file ... in non-clean builds (WiX v3.14.0.1703).

I.e. even though build gets triggered -- actual wxs file doesn't get regenerated.

computerquip-work commented 1 year ago

Modifying the project file that defines the harvest rule also doesn't trigger a rebuild it seems. I've been manually deleting the generated .wxs files. :(

grochoge commented 6 months ago

Was there a solution for this?

I'm running into this harvesting the entire binary directory from another project. Unfortunately the MSBuild Copy task preserves the original modified date.

As a workaround I added a target to delete the generated .wxs files on build:

  <Target Name="ForceReharvest" BeforeTargets="HarvestDirectory">
    <Delete Files="$(IntermediateOutputPath)_%(HarvestDirectory.ComponentGroupName)_dir.wxs"/>
  </Target>