search

wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 24 forks source link

Heat fails to suppress VB6 registry entries when -svb6 is combined with -scom #5982

Closed t-johnson closed 4 years ago

t-johnson commented 5 years ago

Using Wix build 3.11.2318.0 Related to heat.exe and using the scom and svb6 command line options together.

To reproduce, you will need a COM dll build in VB6

When running the command:

heat file -scom -svb6 -o out.txt

the out.txt file contains RegistryValue entries for the MSVBVM60.DLL library, which should be suppressed by the -svb6 command option

t-johnson commented 5 years ago

The following is how i am working around it this issue: https://github.com/t-johnson/wix3/commit/1b6454cd42e981f65228807fb8371a8fdbc09eb1

barnson commented 5 years ago

Please submit a pull request against https://github.com/wixtoolset/wix4.

t-johnson commented 5 years ago

Neil - i would not want to change the behavior of the -scom flag by itself, people might be depending on the current behavior (even it if it not intended). Which is why i just added suppression of the VB6 registry entries when the -scom and -svb6 are combined.

On Mon, Apr 15, 2019 at 1:13 PM Neil Sleightholm notifications@github.com wrote:

Chipping in as the original author of -svb6. Not too sure it makes sense to specify both options, if you are suppressing com then there shouldn't be any need to also suppress the vb6 com entries. Having said that it looks like -scom is not working as I would expect.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wixtoolset/issues/issues/5982#issuecomment-483339337, or mute the thread https://github.com/notifications/unsubscribe-auth/ALA1n_ZjtpImAP9hQIVYJtPmUcGciGYEks5vhLMfgaJpZM4clJwV .

nsleigh commented 5 years ago

Sorry I deleted my comment as I realised I was missing the point of the -scom flag.

t-johnson commented 5 years ago

no problem. i wondered why i got an email and didn't see the comment on github