wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 24 forks source link

Accessibility: Screen reader not reading the "Installation was successful" message #6586

Closed SteveL-MSFT closed 3 years ago

SteveL-MSFT commented 3 years ago

Bugs

If this issue is a bug:

3.1.1

N/A

N/A

.NET 6 RC1

10.0.19043

Install https://github.com/PowerShell/PowerShell/releases/download/v7.1.4/PowerShell-7.1.4-win-x64.msi with a screen reader, get to the end of the installation

Where it shows the built-in "The installation was successful" message in the dialog, this text isn't read by a screen reader.

barnson commented 3 years ago

That isn't a WixUI dialog, it's one your team wrote.

SteveL-MSFT commented 2 years ago

@barnson to be clear, when you say "your team", you mean the Windows installer team? The PowerShell wix doesn't define that dialog or text https://github.com/PowerShell/PowerShell/blob/master/assets/wix/Product.wxs

rseanhall commented 2 years ago

A quick glance shows this line:

<UIRef Id="CustomWixUI_InstallDir" />

CustomWixUI_InstallDir is not something provided by WiX, that's a custom UI code that's somewhere in your source.

barnson commented 2 years ago

https://github.com/PowerShell/PowerShell/blob/master/assets/wix/Product.wxs#L111

SteveL-MSFT commented 2 years ago

Thanks! I'll have someone on my team look into this.

robmen commented 2 years ago

@SteveL-MSFT I'm evaluating issues that are external but required core WiX maintainers' time to resolve.

Can you help me understand a) why this issue was opened against the WiX Toolset initially and b) why a follow-up was required to point out the exact location of the customization in the PowerShell codebase? Thanks.