wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

ExePackage exitCode ERROR_SUCCESS_REBOOT_REQUIRED (0xbc2) takes precedence over MsiPackage ERROR_INSTALL_FAILURE (0x643) #6762

Closed adnanshaheen closed 2 years ago

adnanshaheen commented 2 years ago

Triage

If an ExePackage returns ERROR_SUCCESS_REBOOT_REQUIRED and following MsiPackage returns ERROR_INSTALL_FAILURE. The exitCode set by bootstrapper is ERROR_SUCCESS_REBOOT_REQUIRED instead of ERROR_INSTALL_FAILURE.

Discussions and support

The failure to install MSI error codes must take priority over ERROR_SUCCESS_REBOOT_REQUIRED

Instructions

Bugs

Have a bootstrapper with exePackage that requires a reboot to install (because some dlls might be in use). Have an MSI condition that fail to install the MSI package (e.g. windows version mismatch or any registry check to verify a service/dll availability). The exePackage would exit with code 0xbc2, and MsiPackage would exit with 0x643.

The MSI exit code is fatal error, and should be prioritized over reboot required for exe package.

[3F2C:5990][2022-04-06T16:48:13]i301: Applying execute package: vcredist_x64.exe, action: Install, path: C:\ProgramData\Package Cache\A55510A8C9708B2C68B39CD50BBCAF86E2C885F0\vc_redist.x64.exe, arguments: '"C:\ProgramData\Package Cache\A55510A8C9708B2C68B39CD50BBCAF86E2C885F0\vc_redist.x64.exe" /norestart /q /chainingpackage ADMINDEPLOYMENT'
[3F2C:5990][2022-04-06T16:48:27]e000: Error 0x80070bc2: Process returned error: 0xbc2
[3F2C:5990][2022-04-06T16:48:27]e000: Error 0x80070bc2: Failed to execute EXE package.
[18B4:3B90][2022-04-06T16:48:27]i319: Applied execute package: vcredist_x64.exe, result: 0x0, restart: Required
[3F2C:5990][2022-04-06T16:48:27]i301: Applying execute package: PlatformVerifier.x64.exe, action: Install, path: C:\ProgramData\Package Cache\DB079A158AFB73FC7F2F3DC05495E5797D7B5981\PlatformVerifier.x64.exe, arguments: '"C:\ProgramData\Package Cache\DB079A158AFB73FC7F2F3DC05495E5797D7B5981\PlatformVerifier.x64.exe"'
[18B4:3B90][2022-04-06T16:48:27]i319: Applied execute package: PlatformVerifier.x64.exe, result: 0x0, restart: None
[3F2C:5990][2022-04-06T16:48:27]i323: Registering package dependency provider: {A1AB5CA5-0CD1-4F01-A477-CD61B0D26C98}, version: 3.0.13.0, package: MsiPackagex64.msi
[3F2C:5990][2022-04-06T16:48:27]i301: Applying execute package: MsiPackagex64.msi, action: Install, path: C:\ProgramData\Package Cache\{A1AB5CA5-0CD1-4F01-A477-CD61B0D26C98}v3.0.13.0\MsiPackagex64.msi, arguments: ' ARPSYSTEMCOMPONENT="1" MSIFASTINSTALL="7" SKIPPLATFORMCHECK="0" BUNDLEID="{a3b1aa66-11c7-4cd3-8e86-8b87144d7fd6}" MSI_ARG="MsiPackageArg" CONFIGURATION_FILE_PATH="C:\Windows\TEMP\tmpFA16.tmp" TRANSFORMS=""'
[3F2C:5990][2022-04-06T16:48:27]e000: Error 0x80070643: Failed to install MSI package.
[3F2C:5990][2022-04-06T16:48:27]e000: Error 0x80070643: Failed to execute MSI package.
[18B4:3B90][2022-04-06T16:48:27]e000: Error 0x80070643: Failed to configure per-machine MSI package.
[18B4:3B90][2022-04-06T16:48:27]i319: Applied execute package: MsiPackagex64.msi, result: 0x80070643, restart: None
[18B4:3B90][2022-04-06T16:48:27]e000: Error 0x80070643: Failed to execute MSI package.
[3F2C:5990][2022-04-06T16:48:27]i318: Skipped rollback of package: MsiPackagex64.msi, action: Uninstall, already: Absent
[18B4:3B90][2022-04-06T16:48:27]i319: Applied rollback package: MsiPackagex64.msi, result: 0x0, restart: None
[3F2C:5990][2022-04-06T16:48:27]i329: Removed package dependency provider: {A1AB5CA5-0CD1-4F01-A477-CD61B0D26C98}, package: MsiPackagex64.msi
[3F2C:5990][2022-04-06T16:48:27]i351: Removing cached package: MsiPackagex64.msi, from path: C:\ProgramData\Package Cache\{A1AB5CA5-0CD1-4F01-A477-CD61B0D26C98}v3.0.13.0\
[3F2C:5990][2022-04-06T16:48:27]i351: Removing cached package: PlatformVerifier.x64.exe, from path: C:\ProgramData\Package Cache\DB079A158AFB73FC7F2F3DC05495E5797D7B5981\
[3F2C:5990][2022-04-06T16:48:27]i351: Removing cached package: vcredist_x64.exe, from path: C:\ProgramData\Package Cache\A55510A8C9708B2C68B39CD50BBCAF86E2C885F0\
[3F2C:5990][2022-04-06T16:48:27]i372: Session end, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{a3b1aa66-11c7-4cd3-8e86-8b87144d7fd6}, resume: None, restart: Required, disable resume: No
[3F2C:5990][2022-04-06T16:48:27]i330: Removed bundle dependency provider: {a3b1aa66-11c7-4cd3-8e86-8b87144d7fd6}
[3F2C:5990][2022-04-06T16:48:27]i352: Removing cached bundle: {a3b1aa66-11c7-4cd3-8e86-8b87144d7fd6}, from path: C:\ProgramData\Package Cache\{a3b1aa66-11c7-4cd3-8e86-8b87144d7fd6}\
[3F2C:5990][2022-04-06T16:48:27]i371: Updating session, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{a3b1aa66-11c7-4cd3-8e86-8b87144d7fd6}, resume: None, restart initiated: No, disable resume: No
[18B4:3B90][2022-04-06T16:48:27]i399: Apply complete, result: 0x80070643, restart: Required, ba requested restart:  No
[18B4:3B90][2022-04-06T16:48:27]i500: Shutting down, exit code: 0xbc2
patalexandre commented 2 years ago

Wanted to add that (as users) we do see a similar behavior when installing Microsoft Power BI Desktop (in the example, we used the 2.97.861.0 version of PBI Desktop).

Burn 3.11.2318.

The MSI for PBI Desktop quits with error code 1618 (ERROR_INSTALL_ALREADY_RUNNING), the WiX installer correctly grabs an 0x80070652 return code, but still exits with 0x0 instead of reflecting the actual MSI error code.

[0A40:0E4C][2022-03-31T12:35:09]i301: Applying execute package: ProductMSI, action: Install, path: C:\ProgramData\Package Cache\{b9c12118-21d7-4435-a809-013fe03e9a9b}v2.97.861.0\PBIDesktop_x64.msi, arguments: ' MSIFASTINSTALL="7" ACCEPT_EULA="1" TRANSFORMS=":1036" ENABLECXP="" INSTALLDESKTOPSHORTCUT="0" INSTALLLOCATION="" INTERNETEXPLORERVERSION="" NETFRAMEWORK45="528372" REG_ENABLECXP="" REG_INSTALLDESKTOPSHORTCUT="" REG_SHOWLEADGENDIALOG="" UPDATE_CHECK_URL="https://go.microsoft.com/fwlink/?LinkID=524399" UICULTURECHANGED="1" DISABLE_UPDATE_NOTIFICATION="1" ARPSYSTEMCOMPONENT="1"'
[0A40:0E4C][2022-03-31T12:35:13]e000: Error 0x80070652: Failed to install MSI package.
[0A40:0E4C][2022-03-31T12:35:13]e000: Error 0x80070652: Failed to execute MSI package.
[17A8:2FE4][2022-03-31T12:35:13]e000: Error 0x80070652: Failed to configure per-machine MSI package.
[17A8:2FE4][2022-03-31T12:35:13]i000: Exiting bootstrapper application
[17A8:2FE4][2022-03-31T12:35:13]i000: Exit code: Success
[17A8:2FE4][2022-03-31T12:35:13]i319: Applied execute package: ProductMSI, result: 0x80070652, restart: None
[17A8:2FE4][2022-03-31T12:35:13]e000: Error 0x80070652: Failed to execute MSI package.
[0A40:0E4C][2022-03-31T12:35:13]i318: Skipped rollback of package: ProductMSI, action: Uninstall, already: Absent
[17A8:2FE4][2022-03-31T12:35:13]i319: Applied rollback package: ProductMSI, result: 0x0, restart: None
[0A40:0E4C][2022-03-31T12:35:13]i329: Removed package dependency provider: {b9c12118-21d7-4435-a809-013fe03e9a9b}, package: ProductMSI
[0A40:0E4C][2022-03-31T12:35:13]i351: Removing cached package: ProductMSI, from path: C:\ProgramData\Package Cache\{b9c12118-21d7-4435-a809-013fe03e9a9b}v2.97.861.0\
[0A40:0E4C][2022-03-31T12:35:13]i372: Session end, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{b2fe3d16-1d6c-4e70-b136-d877d5e3c8bb}, resume: None, restart: None, disable resume: No
[0A40:0E4C][2022-03-31T12:35:13]i330: Removed bundle dependency provider: {b2fe3d16-1d6c-4e70-b136-d877d5e3c8bb}
[0A40:0E4C][2022-03-31T12:35:13]i352: Removing cached bundle: {b2fe3d16-1d6c-4e70-b136-d877d5e3c8bb}, from path: C:\ProgramData\Package Cache\{b2fe3d16-1d6c-4e70-b136-d877d5e3c8bb}\
[0A40:0E4C][2022-03-31T12:35:13]i371: Updating session, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{b2fe3d16-1d6c-4e70-b136-d877d5e3c8bb}, resume: None, restart initiated: No, disable resume: No
[17A8:2FE4][2022-03-31T12:35:13]i000: Exiting bootstrapper application
[17A8:2FE4][2022-03-31T12:35:13]i000: Exit code: Success
[17A8:2FE4][2022-03-31T12:35:13]i399: Apply complete, result: 0x80070652, restart: None, ba requested restart:  No
[17A8:2FE4][2022-03-31T12:35:13]i500: Shutting down, exit code: 0x0
[17A8:2FE4][2022-03-31T12:35:13]i500: Shutting down, exit code: 0x0
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: ACCEPT_EULA = 1
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: DISABLE_UPDATE_NOTIFICATION = 1
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: ENABLECXP = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: INSTALLDESKTOPSHORTCUT = 0
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: INSTALLLOCATION = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: INTERNETEXPLORERVERSION = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: LANGUAGE = :1036
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: NETFRAMEWORK45 = 528372
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: REG_ENABLECXP = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: REG_INSTALLDESKTOPSHORTCUT = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: REG_SHOWLEADGENDIALOG = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: UICULTURECHANGED = 1
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: UPDATE_CHECK_URL = https://go.microsoft.com/fwlink/?LinkID=524399
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleAction = 5
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleElevated = 1
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleLog = c:\temp\PowerBISetup\PowerBISetup.Log
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleLog_ProductMSI = c:\temp\PowerBISetup\PowerBISetup_000_ProductMSI.Log
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleManufacturer = Microsoft Corporation
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleName = Microsoft PowerBI Desktop (x64)
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleOriginalSource = C:\temp\PowerBI issue\v2.97\PBIDesktopSetup_x64.exe
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleOriginalSourceFolder = C:\temp\PowerBI issue\v2.97\
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleProviderKey = {b2fe3d16-1d6c-4e70-b136-d877d5e3c8bb}
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleRollbackLog_ProductMSI = c:\temp\PowerBISetup\PowerBISetup_000_ProductMSI_rollback.Log
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleSourceProcessFolder = C:\temp\PowerBI issue\v2.97\
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleSourceProcessPath = C:\temp\PowerBI issue\v2.97\PBIDesktopSetup_x64.exe
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleTag = 
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleUILevel = 2
[17A8:2FE4][2022-03-31T12:35:13]i410: Variable: WixBundleVersion = 2.97.861.0
[17A8:2FE4][2022-03-31T12:35:13]i007: Exit code: 0x0, restarting: No
rseanhall commented 2 years ago

0x80070652/1618/ERROR_INSTALL_ALREADY_RUNNING is not relevant to this issue. You appear to be running a custom BA that is ignoring the error. Please create a separate discussion or email the wix-users mailing list.