wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 36 forks source link

Add ability to specify that a custom action reference depends on architecture #6821

Open rseanhall opened 2 years ago

rseanhall commented 2 years ago

Feature requests

If this issue is a feature request:

UI.wixext is currently always referencing its custom action .dll for the ui:WixUI element because it generates the custom action definitions when the element is compiled. It is deferring to compile time instead of including the custom action definitions in its .wixlib because it only wants to have one definition for each dialog so that it can be easily reused by people creating their own dialog sets. It's impossible today to have multiple custom actions with everything the same except the source Binary because it would cause duplicate errors.

UI.wixext could use the preprocessor to define the custom actions with different names for different architectures, but then it would not be easy for the dialogs to be reused.

The UI extension is currently using the plain name WixUIValidatePath to reference the custom action:

<Publish Dialog="BrowseDlg" Control="OK" Event="DoAction" Value="WixUIValidatePath" Order="3" />

This issue is asking to keep the plain name in the source code but at link time resolve that to the right name and bring in the section with that custom action. Needs to be designed.

barnson commented 2 years ago

To make sure I understand what you're saying, you're asking for the ability to reference a customaction/architecture tuple and have the backend pick the right one based on the package target architecture? If so, 👍.

rseanhall commented 2 years ago

I updated the bottom section. It is asking for it to be resolved before linking.