WiXCop v4 Upgrade leaves DestinationLongName alone

[chrpai]

Bugs

If this issue is a bug:

• Which version of WiX are you building with? 4.0.3

• Which version of Visual Studio are you building with (if any)? 17.8.0

• Which version of the WiX Toolset Visual Studio Extension are you building with (if any)? Heatwave 1.0.2

• Describe the problem and the steps to reproduce it.

Create a v3 project with a fragment containing a CopyFile@DestinationLongName attribute. It will build with a deprecation warning. Convert it to v4 using Heatwave/WixCop. It will say conversion succeeded. Nothing in the conversion log mentions this attribute. However the build v4 build will fail wwith WIX0004 saying the attribute is unexpected.

    <Fragment>
        <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER">
      <Component Id="test">
        <File Id="test" Source="C:\vfcompat.dll">
          <CopyFile Id="dupe" DestinationLongName="somethinglegacy.dll"/>
        </File>
      </Component>
        </ComponentGroup>
    </Fragment>

• Describe the behavior you expected and how it differed from the actual behavior.

I'd expect wixcop to rename DestinationLongName to DestinationName or report a conversion failure if there is a reason this isn't safe to do automatically.

[chrpai]

@barnson I can take this one