wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
129 stars 24 forks source link

wix format doesn't save formatted file in-place #8181

Closed pedro-w closed 6 months ago

pedro-w commented 6 months ago

WiX Version

5.0.0+41e11442

.NET or MSBuild or Visual Studio Version

8.0.204

HeatWave Version

N.A

Windows Version

Win11 22H2

Repro Repo

https://github.com/pedro-w/wix-format

Repro Steps

  1. In a directory with the file me.wxs from the repo above (can be any wxs file which needs formatting, I think)
  2. Command wix format me.wsx

Actual Result

InMemoryXml(1) : information WIX0005: [Converted] This file contains an XML declaration on the first line. (DeclarationPresent)
InMemoryXml(2) : information WIX0002: [Converted] The whitespace preceding this comment is incorrect. (WhitespacePrecedingNodeWrong)
InMemoryXml(3) : information WIX0002: [Converted] The whitespace preceding this comment is incorrect. (WhitespacePrecedingNodeWrong)
InMemoryXml(4) : information WIX0003: [Converted] The whitespace preceding this end element is incorrect. (WhitespacePrecedingEndElementWrong)
InMemoryXml : information WIX0005: [Converted] This file contains an XML declaration on the first line. (DeclarationPresent)
InMemoryXml : information WIX0002: [Converted] The whitespace preceding this comment is incorrect. (WhitespacePrecedingNodeWrong)
InMemoryXml : information WIX0002: [Converted] The whitespace preceding this comment is incorrect. (WhitespacePrecedingNodeWrong)
InMemoryXml : information WIX0003: [Converted] The whitespace preceding this end element is incorrect. (WhitespacePrecedingEndElementWrong)

Expected Result

Acknowledgements

pedro-w commented 6 months ago

I had a look, seems like a straightforward fix?

pedro-w commented 6 months ago

This can be closed now the PR is merged