wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
130 stars 24 forks source link

DisplayInternalUICondition doesn't work correctly #8695

Closed Bondarenko1990 closed 3 months ago

Bondarenko1990 commented 3 months ago

WiX Version

4.0.0

.NET or MSBuild or Visual Studio Version

.NET 8.0

HeatWave Version

1.0.2.1

Windows Version

23H2

Repro Repo

No response

Repro Steps

I upgraded Wix Bootstrapper project to WIX 4.0.0. And I have problems with displaying internal UI. The only problem is when uninstalling the application. I want the internal UI of msi package not to be shown. With Wix 3 there were no such problems, everything worked properly. Tell me how I can solve this problem, please. This is the code before upgrading to WIX 4 and everything worked fine.

    <MsiPackage Id="Setup" SourceFile="$(var.Setup.TargetPath)" Compressed="yes">
        <MsiProperty Name="AddDesktopShortcut" Value="[AddDesktopShortcutMsiVariable]" />
        <MsiProperty Name="INSTALLFOLDER" Value="[InstallFolder]" />
    </MsiPackage>

    <MsiPackage DisplayInternalUI="no" Id="SetupMSI" ForcePerMachine="yes" 
                         SourceFile="$(var.TargetDir)\......x64.msi" Compressed="yes">
    </MsiPackage>

And this is the code after the update(Wix 4.0.0)

<MsiPackage Id="Setup" SourceFile="$(var.Setup.TargetPath)" Compressed="yes">
        <MsiProperty Name="AddDesktopShortcut" Value="[AddDesktopShortcutMsiVariable]" />
        <MsiProperty Name="INSTALLFOLDER" Value="[InstallFolder]" />
    </MsiPackage>

    <MsiPackage bal:DisplayInternalUICondition="no" Id="SetupMSI" ForcePerMachine="yes" 
                      SourceFile="$(var.TargetDir)\......x64.msi" Compressed="yes">
    </MsiPackage>

And now when I uninstall the application, this dialog box appears. It shouldn't appear. I think bal:DisplayInternalUICondition="no" doesn't work. And I tried to remove ......x64.msi using the command line by running the command (msiexec.exe /i "C:****.msi" /qn). It installs silently in the background without displaying any windows.

Actual Result

There is dialog window FileInUse. image

Expected Result

There are no windows. Uninstall successfully completed. image

Acknowledgements

ranchoebuka commented 3 months ago

@Bondarenko1990 . Have you tried using bal:DisplayInternalUICondition="WixBundleAction = 6". This gives the same behaviour with Wix3.0.

It was mentioned on this page (https://wixtoolset.org/docs/fourthree/faqs/). scroll down to Removal of DisplayInternalUI section.

Bondarenko1990 commented 3 months ago

@ranchoebuka thanks for the answer. But I wouldn't want to show the MSI UI. What parameter should I use in the property bal:DisplayInternalUICondition?

barnson commented 3 months ago

WiX doesn't use issues for support. You can use the GitHub discussions area or Stack Overflow.