wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
130 stars 24 forks source link

Wix 5 Standard BA - bal:Condition not localizable anymore #8746

Open gvkries opened 2 months ago

gvkries commented 2 months ago

WiX Version

5.0.1

.NET or MSBuild or Visual Studio Version

Visual Studio 2022 Version 17.11.3

HeatWave Version

1.0.4.5

Windows Version

Win11 23H2

Repro Repo

No response

Repro Steps

When using a standard bootstrapper application with a localized message in a condition, the message is not getting localized.

Sample: <bal:Condition Message="#(loc.StringId)" Condition="[...]" />

I think this happens because BalConditionsParseFromXml() is called before the localization file is loaded: https://github.com/wixtoolset/wix/blob/dd2fe20d9fe58719445411524bd730495140d02f/src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp#L2835

Actual Result

The raw message is shown, e.g. `#(loc.StringId)'.

Expected Result

The localized message should be shown instead of the localization identifier.

Acknowledgements