search

wiz64 / saavn-web-ui

Saavn Music Player & MP3 Downloader - Web UI for saavn-unofficial api. Search and play ad-free music.
https://saavn-web-ui.vercel.app
MIT License
71 stars 26 forks source link

Downloadability of music #18

Closed romulan-overlord closed 1 month ago

romulan-overlord commented 1 month ago

Hey there. Love the project.

Small suggestion: you have a separate download option for each song, but that isn't working for me. Instead, I saw that your audio tag in the HTML has controlslist set to nodownload. I just removed that setting and was able to download it from the player interface itself.

Thought it might be better to leave that as a feature instead of a separate download routine, or perhaps keep both?

wiz64 commented 1 month ago

Hey there. Love the project.

Small suggestion: you have a separate download option for each song, but that isn't working for me. Instead, I saw that your audio tag in the HTML has controlslist set to nodownload. I just removed that setting and was able to download it from the player interface itself.

Thought it might be better to leave that as a feature instead of a separate download routine, or perhaps keep both?

This is because if you download from the embeded player the format isn't playable everywhere and contains no metadata info which is why i created the seperate button in first place, i am bringing back the download api because of requests from userbase :)

romulan-overlord commented 1 month ago

0o0, makes a lot of sense.

On Mon, 5 Aug 2024 at 16:13, wiz64 @.***> wrote:

Hey there. Love the project.

Small suggestion: you have a separate download option for each song, but that isn't working for me. Instead, I saw that your audio tag in the HTML has controlslist set to nodownload. I just removed that setting and was able to download it from the player interface itself.

Thought it might be better to leave that as a feature instead of a separate download routine, or perhaps keep both?

This is because if you download from the embeded player the format isn't playable everywhere and contains no metadata info which is why i created the seperate button in first place, i am bringing back the download api because of requests from userbase :)

— Reply to this email directly, view it on GitHub https://github.com/wiz64/saavn-web-ui/issues/18#issuecomment-2268763866, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMA6RZPDI5JMOT7PMD6TSLZP5JMXAVCNFSM6AAAAABLXXBN3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG43DGOBWGY . You are receiving this because you authored the thread.Message ID: @.***>