search

wizard97 / ArduinoProcessScheduler

An Arduino object oriented process scheduler designed to replace them all
46 stars 16 forks source link

ci: build with platformio and github actions #21

Closed thijstriemstra closed 3 years ago

thijstriemstra commented 3 years ago

Build example on d1 mini and uno boards using platformio.

thijstriemstra commented 3 years ago

@wizard97 can you enable github actions for this repository? I would've hoped my PR would enable/trigger it but alas, no.

See https://github.com/wizard97/ArduinoProcessScheduler/actions

thijstriemstra commented 3 years ago

@wizard97 should be good now.

thijstriemstra commented 3 years ago

at some point I will probably use this library on ESP32. Any reason RingBuf disabled support for ESP32 or is it just untested?

thijstriemstra commented 3 years ago

ping @wizard97

wizard97 commented 3 years ago

Sorry for the slow turnaround. The ESP32 software stack was just not really developed at the time I was working on this library. Totally interested in making sure it is supported.

Does it not build on ESP32 currently? Also, can you squash the latter 2 commits since together they are effectively nops?

thijstriemstra commented 3 years ago

Does it not build on ESP32 currently?

No, it seems RingBuf explicitly disabled ESP32 supported, see log here: https://github.com/thijstriemstra/ArduinoProcessScheduler/runs/1784375565 (showing why it's useful to have these github actions to figure out if something's working/still working).

Also, can you squash the latter 2 commits since together they are effectively nops?

Github has a 'squash commits' option when you merge a pull request. This will squash the commits into a single one.

@wizard97 can you also make a new release once this pr is merged?

thijstriemstra commented 3 years ago

ping @wizard97

wizard97 commented 3 years ago

Thanks, sorry for the delayed response!