search

wizardamigos / profiles

Fork to make your profile
http://wizardamigos.com/profiles
MIT License
6 stars 45 forks source link

[feature] search & filter bar javascript logic #10

Open serapath opened 6 years ago

serapath commented 6 years ago

to make the search & filter bar do something

jameslin3263 commented 6 years ago

Hi, I finally finished it, Sorry for the delay It still needs to filter the duplication of the reports, which had been fetch. I will try to find out the solution to solve it. Additionally, I haven't done some CSS in this component, so if anyone has some ideas maybe we can try these https://github.com/jameslin3263/Amigo-search-bar-issue @serapath @ninabreznik @kiecoo @TzuYuanLiu

serapath commented 6 years ago

@jameslin3263 very nice. I would recommend you to make an index.html in your github repository and activate github page under "Settings".

Then - on your github repo, you can edit the title description and a link that describes your repository, so people can click the link (which would link to the github page of your repo) to see a little demo or preview. If you do everything right, the link will be: (https://jameslin3263.github.io/Amigo-search-bar-issue)

Inside of the index.html you just use the npm-require script tag and then require your own module by writing: var searchbar = require('./src/index.js') ..that might just work.

But I didn't check your code in detail and see that you use a service worker too. But once you have the github page, you can ping me and i try to help debugging :-)