Design - tab

[Mehrabbruno]

@todo

114

• [x] Design - Tab components
  • @input 📦 historyLogsPopover_v0.0.1 from #119
  • @input 📦 fileExplorePopover_v0.0.1 from #120
  • @input 📦 applicationPopover_v0.0.1 from #116
  • @input 📦 permissionPopover_v0.0.1 from #117
    • @input 📦 actionsPopover_v0.0.1 from #118
    • [x] Tab Name
    • [x] Next and Prev buttons to toggle between directory files
    • [x] Close button (to close the tab
    • [x] Record an explanatory video for Tab Component and add it in the header description
  • @output 📦 tab_v0.0.1 from comment
    • next #114

[Mehrabbruno]

Worklog 1 2022.10.21

• done Design - Tab components - 1min
  • done Tab Name - 1min
  • done Next and Prev buttons to toggle between directory files - 1min
  • done Close button (to close the tab - 1min
  • done Record an explanatory video for Tab Component and add it in the header description - 1min
  • @output 📦 tab_v0.0.1

[serapath]

feedback 2022.10.14

the worklog is missing the link to the worklog video, could you edit it and add that? i agree though that you could add a generic task for the project management overhead to book time on, which brings me to the missing times behind each of those tasks that should be added too :-) otherwise, great explanation.

one more thing: probably also applicable for most task issues (not worklog comments)

=>

The @inputshould not appear before the task that produces that input. The task that produces the input doesn't need to even show up as a sub bullet task at all, but if it does, it should not appear before the input is used.

Then, in this issue example, the subtask Tab Component (contains) is basically a task that needs to use the inputs and integrate them into the current component

---

One thing that i believe needs to change is the icon for the actions. The vertical ". . ." menu doesn't work well with the ". . ." to show the tabs not visible because of screen widht limit. They look the same and i don't expect actions when i see ". . ." but then sometimes more tabs when i click ". . .". see here

but then later you also show once this which has different icons and that works, but one issue still remains, which is the user doesn't see which is the currently active action.

They see the file name of the currently active file They see the icon of the currently active program (e.g. video player) You don't see the currently active action

Basically microsoft word has those action icons that you can just click to trigger an action, but you can also press and hold to make a dropdown appear to select a different action.

here is an exagerated verbose version of that

maybe all of that can still be integrated into a menu? ...but technically important is that a user clicking the button triggers the action and only if they maybe click and hold or click the tiny arrow next to the icon they will see the dropdown/dropup to select a different action

[serapath]

feedback 2022.10.22

short feedback regarding the < and > button for tabs. I think they should not just be visible on hover, but also on active. I would maybe even go as far to say they should always be visible.

Only tabs which open tile.json files will have them anyway and even amongst those, only the tile json files that actually define previous and next options will show them, so mostly they won't be visible, but when they are defined, i think it is important for the user to be aware and just showing them on hover means a user can easily miss them when they come to a workshop with many open tabs and don't hover over a specific tab, which i think is not great.

So maybe let's just make them always visible and not just on hover :-)

[Mehrabbruno]

Proposals 2022.10.24

• [ ] Make the arrow keys CTA for navigation always visible
• [ ] In the Figma component description, worklog and/or explanatory video, mention "only files which define previous and next options will see the arrows. For others it will be disable"
• @input 📦 tab_v0.0.1
• @output ❓ [tab_v0.0.2]()

[serapath]

feedback 2022.10.26

:+1: