Open Mehrabbruno opened 1 year ago
done
Design - Collapsed Bookmarks pop-over (toggles on onClick). it contians - 1min
done
collapsedBookmarksPopover (contains) - 1min
done
pop-over header (fixed to the top and contains title, total number of collapsed bookmarks and close button) - 1min
done
Collapsed Bookmarks container - 1min
done
Bookmarks (contains Folder icon, title, toggle icon, and close button) - 1min
done
When clicked user gets a dropdown list of children tabs - 1min
done
Search input (contains search icon, inputField and close icon when added text) - 1min
done
Record an explanatory video for Collapsed Bookmarks Popover and add it in the header description - 1min
@output
π¦ collapsedBookmarksPopover_v0.0.1
feedback 2022.10.14
same thing as always
The collapsed bookmark component is great, it has the same issues as the non-collapsed version in that it needs to change and be more like a file explorer popover, but other than that the technique to fit it into a mobile view is great.
feedback 2022.10.22
AS for the normal bookmarks popover, i think they should be the same. It is a responsive component, but maybe we can design them as one component and show the different states, like collapsed and expanded or whatever you call that, so it works on mobile and desktop. They should be merged into one component imho.
done
Design - collapsedBookmarksPopover_v0.0.2 - 20min
done
remove header, and footer from the component.done
place the content inside the #125 content body@output
π¦ collapsedBookmarksPopover_v0.0.2
feedback 2022.10.31
Here is my feedback regarding some unclear issues around clicking on a bookmark to open it or instead triggering the bookmark popover and selecting an entry from their and what should happen if those entries ate tile json files or sub entries of tile json files.
https://share.vidyard.com/watch/YrRKFYfptWFKFz5yT4ScGM?
Let me know if that made things more clear. I have another previous video on the bookmarkPopover issue that also tries to explain the details.
ALSO If the bookmark is a folder, it opens it in a new single tile whith the file explorer program and shows the contents of that folder in that tiles.
There is no such thing as a custom group. Things are either tile json files or files or folders. If you want a custom group, you create a folder and then create a few symlinks to files. On windows they are sometimes called "short cuts" and when you click them, they open the file or folder that they link to and you can add a bunch of those into a custom folder.
So in that case you get a tile that looks like this (without a file tree)
And you can then maybe double click entries to "enter" a folder or open a file.
Maybe it would even display a
..
folder to go "one level up" :-)
But that is subject of the file explorer component issue i would say.
Imagine that would be the file explorer and imagine the Company
entry was "bookmarked".
Then when you open the bookmark popover for the Company
bookmark, it will show the bookmark popover with the file explorer expanded and Company
already highlighted and indicated that it is pinned as a bookmark.
That is what i mean if it helps.
Clicking another bookmark will show the same file explorer, but maybe instead it will highlight project document
because that is the bookmark we clicked on open bookmark popover so therefore it starts with that one highlighted instead :-)
there is no "custom group" only folders which can contain files, folders, tile json files or links to files, links to folders or links to tile json files
there is the bookmark popover and there is the action to do something immediately if you don't want to go to first open the bookmark popover. I think that default quick action should be to open a bookmark in a new tile - if that's not what you want, you click to open the bookmark popover and select the action from there
@todo
115
@input
π¦popOvers_v0.0.1 (Deprecated)
from #113@output
π¦collapsedBookmarksPopover_v0.0.1
fromcomment
@input
π¦collapsedBookmarksPopover_v0.0.1
@input
π¦popoverContainer_v0.0.1
from #125@output
π¦collapsedBookmarksPopover_v0.0.2
fromcomment
@info
This pop-over is designed for to be placed in component
Design TWM - bookmarksContainer_v0.0.1