Open jp1ac4 opened 6 months ago
Hi @jp1ac4, I'll love to work on this issue. But I have a few things to clarify:
Hi @Anyitechs, thanks for offering to work on this issue.
- Is this the optional filter you're referring to that was added in #921 ?
That's correct.
- Do we need to replace all existing filtering logic with this or only replace the ones related to filtering txids?
I'm not sure if this is what you mean, but you can update the GUI's list_spend_txs function to include this optional filter parameter and then update all usages of this function in the GUI accordingly. In most cases, no filtering is required and so you can set the new parameter to None
, but where filtering is being done here, you can replace it with a suitable call to the list_spend_txs
function.
Feel free to ask if you have any questions.
Thank you for the response, @jp1ac4. I'll work on it and send in a draft PR for Concept ACK.
Hey @Anyitechs are you still working on this?
An optional filter was added in https://github.com/wizardsardine/liana/pull/921.
We can add this to the GUI and replace any existing filtering logic, e.g. https://github.com/wizardsardine/liana/blob/a4d37e36ba46b2e134110c655c7ebe1b3da351f5/gui/src/daemon/mod.rs#L109=#L113.