commands: check `createrecovery` timelock parameter corresponds to recovery path

wizardsardine / liana

The missing safety net for your coins

https://wizardsardine.com/liana

BSD 3-Clause "New" or "Revised" License

317 stars 56 forks source link

commands: check `createrecovery` timelock parameter corresponds to recovery path #1089

Open jp1ac4 opened 5 months ago

jp1ac4 commented 5 months ago

If passing a timelock value to the createrecovery command, we should check if the value corresponds to one of the wallet's recovery paths.

darosior commented 5 months ago

What's the issue with the current behaviour?

jp1ac4 commented 5 months ago

Perhaps it's not a problem as such, but it's currently possible to pass 0, for example, as the timelock value and get a transaction spending all confirmed coins. Without any check, there's more chance to make a mistake with the value passed in and select more coins than expected.