Open pythcoiner opened 2 months ago
What does the delay accomplish here? If it's related to the fact that it's not very intuitive to click outside the modal to close it, I would solve it by adding a close ("x") button instead of inserting a delay. In this way we would still assure that the closure is an action of the user. This is a comment common to many modals in the application, so maybe it should be addressed in a separate issue (if not already present).
What does the delay accomplish here?
Avoid one more click
I feel in the broadcast flow there is too musch click, user already click 2 times (after sign) for broadcast
In that case I think it should not be a modal but a dialog box that appears for x seconds and that doesn't impede the user to continue using Liana in the meanwhile. I see it in many other applications. Usually it is a green box in the bottom of the screen.
Related to that, I noticed that we don't update the status of the transaction, that remains "Ready". This could confuse the user, I would update it to "Broadcasted". That is even more important if we don't require user action to the broadcasted success message, so I think we could tackle it together with this issue.
Broadcast is also the past of broadcast, just to make sure we don't add "broadcasted" again.
I agree this issue is just not the way to go: the problem is the number of clicks. If a transaction is ready, it should be broadcast. If we believe it's important not to (?), then we could add an option either Global or a the tx level to "⬜🔳 Broadcast tx when ready", on by default.