search

wizardsardine / liana

The missing safety net for your coins
https://wizardsardine.com/liana
BSD 3-Clause "New" or "Revised" License
329 stars 58 forks source link

Set bind parameter in GUI installer when defining managed bitcoind config #1423

Open jp1ac4 opened 3 weeks ago

jp1ac4 commented 3 weeks ago

It seems that bitcoind 28.0 may error if there are other instances running on the same machine and bitcoin network due to a port collision. Now that Liana's managed bitcoind has been upgraded to 28.0, we should set the bind parameter (to be confirmed) to a random port to avoid this collision.

User impact is likely to be low given that a user selecting to use managed bitcoind is not expected to be running multiple instances. A short-term workaround would be to either stop other bitcoind instances or edit the managed bitcoind config to specifiy this additional parameter.

jp1ac4 commented 3 weeks ago

Our approach may depend on the outcome of https://github.com/bitcoin/bitcoin/issues/31133.

jp1ac4 commented 2 weeks ago

See also ba553e9ddb104af454d9eff9969c0e37a1f3061a.

jp1ac4 commented 2 weeks ago

On a related note and possibly as part of this fix, the ports used by managed bitcoind could be chosen at runtime. We currently pick some available ports randomly when first installing bitcoind and save these in bitcoin.conf, but these ports might not be available the next time Liana is opened. These newly chosen values could either be passed as command-line arguments or saved to the config file in order to facilitate the use of bitcoin-cli.

Of course any ports used in the daemon config file should be fixed still :)