GUI: "pending" on the home for tx being sent -> should be "pending inclusion in a block"

wizardsardine / liana

The missing safety net for your coins

https://wizardsardine.com/liana

BSD 3-Clause "New" or "Revised" License

321 stars 57 forks source link

GUI: "pending" on the home for tx being sent -> should be "pending inclusion in a block" #230

Closed kloaec closed 1 year ago

kloaec commented 1 year ago

The home currently displays "pending" when a transaction is being SENT. Pending could mean a lot of things, when in this context it just means unconfirmed (but already signed and broadcast). The tag should be clearer, "Pending inclusion in a block"

kloaec commented 1 year ago

Screenshot from 2022-12-15 11-29-54

darosior commented 1 year ago

Or just "unconfirmed"? I think the current label was ported from Revault where it didn't make sense to have an "unconfirmed" label at this stage since the transaction wasn't broadcast before some time.

darosior commented 1 year ago

Related to #231. I think we should just get rid of the Revault terminology everywhere ("Pending", "Broadcast", ..) and just replace it with "unconfirmed" the way described here: https://github.com/wizardsardine/liana/issues/231#issuecomment-1354552317.