GUI: errors about invalid inputs aren't always updated

wizardsardine / liana

The missing safety net for your coins

https://wizardsardine.com/liana

BSD 3-Clause "New" or "Revised" License

309 stars 55 forks source link

GUI: errors about invalid inputs aren't always updated #326

Open darosior opened 1 year ago

darosior commented 1 year ago

Sometimes they don't disappear even if we fixed the input. Here is an instance (but i don't think it is the only one).

edouardparis commented 8 months ago

I believe this issue has a too general scope and it is difficult to find a good resolution to it, but by listing the presence of form::Form, we can test the different user inputs present in:

[x] src/app/view/transactions.rs L332
[x] src/app/view/psbt.rs L77
[x] src/app/view/label.rs L31
[ ] src/app/view/settings.rs
[x] src/app/view/psbts.rs L184
[x] src/app/view/recovery.rs L130 L142
[x] src/app/view/spend/mod.rs L203
[ ] src/installer/view.rs

darosior commented 8 months ago

Opened this a year ago, but iirc my thinking was that the same component would be used in all places where this occurred. Have you tested the inputs in your list? Do they all present this issue?

edouardparis commented 7 months ago

The form component is used multiple time as a User input in the views, but it is in the state module that the entered input is parsed (into a PSBT, an address etc) and checked according to the context (address compatible with current network) etc This issue is difficult to solve in a general way because it all depends on what we do of the user input. I did a check for the list of files and provided links where the validity of the form is updated once the user change his input.