wizardsardine / liana

The missing safety net for your coins
https://wizardsardine.com/liana
BSD 3-Clause "New" or "Revised" License
331 stars 58 forks source link

Editing a PSBT #638

Open kloaec opened 1 year ago

kloaec commented 1 year ago

We currently do not allow to edit a PSBT, only to sign it, and "update" it which is to add new signatures.

It makes sense in some cases to want to edit a PSBT, for example:

This is an expected feature in the PSBT screen. I do not know how this should be done/tracked from a database perspective (txid changes).

pythcoiner commented 1 year ago

what about the UI side, you imagine something ala https://bip174.org/?

darosior commented 1 year ago

In this case we should probably duplicate it as editing any PSBT but an unsigned one would invalidate all signatures. It's a bit of a footgun to give to the user "click here and wipe all signatures you've collected until now". But maybe it's fine even without duplicating it beforehand?