RBF follow-ups - Githubissues

darosior commented 9 months ago

Here are a couple things which didn't warrant holding up the PR but would be nice to have:

[ ] Expand the explicit-RBF-signaling sanity check to all conflicting transactions (https://github.com/wizardsardine/liana/pull/816#discussion_r1417618042)
[x] The "feerate too low" error could include the minimum feerate to be more helpful (https://github.com/wizardsardine/liana/pull/816#discussion_r1416268844)

Added after @jp1ac4 comments:

[ ] We can also check if any directly conflicting transactions are spending unconfirmed change and include these unconfirmed coins as candidates for the replacement transaction (https://github.com/wizardsardine/liana/issues/826#issuecomment-1853058734).
[ ] We should add ancestor info to coin selection candidates when creating a replacement to ensure we pay extra for any parent transactions that have a lower feerate (https://github.com/wizardsardine/liana/pull/873#discussion_r1518611295).
[ ] We should support RBF on a recovery transaction. Currently, the RBF candidate coins all have their sequence set to None.

@jp1ac4 feel free to suggest more.

jp1ac4 commented 9 months ago

We can also check if any directly conflicting transactions are spending unconfirmed change and include these unconfirmed coins as candidates for the replacement transaction (https://github.com/wizardsardine/liana/issues/826#issuecomment-1853058734).

jp1ac4 commented 6 months ago

We should add ancestor info to coin selection candidates when creating a replacement to ensure we pay extra for any parent transactions that have a lower feerate (https://github.com/wizardsardine/liana/pull/873#discussion_r1518611295).

jp1ac4 commented 2 months ago

We should support RBF on a recovery transaction. Currently, the RBF candidate coins all have their sequence set to None.

aaroncarlucci commented 2 months ago

Tried to address the second bullet in the description with #1186.

nondiremanuel commented 1 month ago

I updated the issue description to include Michael's comments. I also divided it in different tasks and marked the second one as completed as per @aaroncarlucci's PR #1186 which was merged (thanks!)

jp1ac4 commented 4 days ago

We should add ancestor info to coin selection candidates when creating a replacement to ensure we pay extra for any parent transactions that have a lower feerate (#873 (comment)).

See https://github.com/wizardsardine/liana/issues/1255.

wizardsardine / liana

RBF follow-ups #853