search

wizardsardine / liana

The missing safety net for your coins
https://wizardsardine.com/liana
BSD 3-Clause "New" or "Revised" License
318 stars 56 forks source link

Incompatible descriptor? #889

Closed 1thales closed 7 months ago

1thales commented 10 months ago

How to reproduce:

  1. Create a bip39 seedphrase. import to electrum, export zpub
  2. Import zpub to sparrow
  3. export descriptor in from sparrow. You get a txt file with three descriptors. Take the first one of the format wpkh([00000000/84h/0h/0h]xpubsomeextendedpublickeyhere/<0;1>/*)#xxxxxx
  4. Import in Liana 4 => Incompatible descriptor

Is this an expected behavior?

pythcoiner commented 10 months ago

You cannot import a descriptor from sparrow, Liana currently only support import descriptor with a timelocked recovery path.

1thales commented 10 months ago

what is the reason for such restriction? I though descriptors to be the end-all standard

darosior commented 10 months ago

Liana does not aim to be a generalist wallet: do one thing and do it well as they say. I also don't believe it'd be possible to reasonably support all the features enabled by Miniscript descriptors in a non-expert wallet. A lot of functionalities and abstractions require that you assume the type of descriptor which is being used.

kloaec commented 9 months ago

Also as this isn't the first time it was asked:

Some users want to use Liana as a multisig wallet. They don't care about the recovery path. While we may, one day, allow such a use case (and maybe even the opposite one of not having a primary path), I strongly believe you can benefit from Liana's features by adding a decaying or expanding multisig recovery, and increasing your primary threshold or moving the "extra keys" into a recovery path.

About the descriptors being a standard, they are, and they aren't! AFAIK Sparrow doesn't handle Miniscript descriptors for example. Liana has a timelock-focused GUI, so we restrict the descriptors to that. Core would accept "anything", but wouldn't display you any useful information about the timelocks (as it's not built for that) in the GUI.

darosior commented 9 months ago

About the descriptors being a standard, they are, and they aren't!

They are a standard. But different wallet support different standards.

-------- Original Message -------- On Jan 10, 2024, 8:03 PM, Kevin Loaec wrote:

Also as this isn't the first time it was asked:

Some users want to use Liana as a multisig wallet. They don't care about the recovery path. While we may, one day, allow such a use case (and maybe even the opposite one of not having a primary path), I strongly believe you can benefit from Liana's features by adding a decaying or expanding multisig recovery, and increasing your primary threshold or moving the "extra keys" into a recovery path.

About the descriptors being a standard, they are, and they aren't! AFAIK Sparrow doesn't handle Miniscript descriptors for example. Liana has a timelock-focused GUI, so we restrict the descriptors to that. Core would accept "anything", but wouldn't display you any useful information about the timelocks (as it's not built for that) in the GUI.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>