search

wizarrrr / wizarr

Wizarr is an advanced user invitation and management system for Jellyfin, Plex, Emby etc.
https://docs.wizarr.dev
MIT License
1.26k stars 87 forks source link

Fix wrong (German) translation on homepage #289

Closed iophobia closed 10 months ago

iophobia commented 10 months ago

I'm aware that Wizarr is localized by Weblate. But as a German user I stumbled over this mishap (see attachment). It seems like the variable for the server name was just turned into a hardcoded "names Server". I've found no way to address that so I thought opening a ticket would make sense.

I'm on v3.4.2 by the way. wizarr

Edit: Okay, seems it's as easy as exchanging %{name}s Server for %{server_name}s Server in the German app.po on line 1133. I'm not accustomed to PRs, so if anybody feels like it, your help would be appreciated.

JamsRepos commented 10 months ago

Hey! If you wish to contribute to translations, you can do so on our Weblate and it'd be great if you could proof read them all and correct where need be. https://hosted.weblate.org/projects/wizarr-v3/wizarr/de/

JamsRepos commented 10 months ago

I've tested this on my local.

Gib deinen Einladungscode für %{server_name}s Server ein! works, i've submitted the suggestion to remove the s on the end, which should work.

Please note, the server name is grabbed from /admin/settings/media and uses the Display Name.

Krallenkiller commented 10 months ago

Since I created the German translation, I can confirm that there were errors in version 3.4.2. These were corrected approximately two weeks ago and are no longer present from version 3.4.8 onwards.