wizbots / labtab

0 stars 0 forks source link

App crashing when trying to make a video #122

Closed internetmosquito closed 5 years ago

internetmosquito commented 5 years ago

In version 1.8.8 the app is crashing every time we try to make a video

The labtab is closed when trying to add the video: reproduce in staging:

Logs attached logs.zip

kapoorutd commented 5 years ago

@internetmosquito I have checked the above mentioned issue by taking the pull from "m_zero" branch and the bug you have shared is not in m_zero branch which is on github v1.8.7 To fix the mentioned issue, I need v1.8.8 build code. Please do the needful.

internetmosquito commented 5 years ago

@kapoorutd not sure what you mean, m_zero and master are identical...I created v1.8.8 from m_zero, merged into master and made tag v1.8.8

Although if I compare them now I see this commit https://github.com/wizbots/labtab/commit/6bb77defa4cdf8908ba7df087c8a423bfc7cd817 which is related with https://github.com/wizbots/labtab/issues/121#issuecomment-472416770

Are you saying this bug is not in m_zero branch? Anyway I would recommend checking with APK I created for this...you can download it here https://github.com/wizbots/labtab/releases/tag/v1.8.8

kapoorutd commented 5 years ago

@internetmosquito This is to inform you that the targetSdkVersion has changed from 23 to 25 and for 25 (i.e nougat) We need some extra permission for accessing URI i.e We need add file provider for api level 25 that is not present in the current code base. So, Please whenever there is any change made for targetSdkVersion in future, let us know. Now I am fixing it and update you.

kapoorutd commented 5 years ago

@internetmosquito We've fixed the above issue and cross check the previous issues. We have pushed the fixes in m_zero branch , Please take a pull from same branch and verify the changes.

internetmosquito commented 5 years ago

thanks, will check! @kapoorutd