search

wizbots / labtab

0 stars 0 forks source link

Sometimes videos are uploaded without creators #135

Open internetmosquito opened 5 years ago

internetmosquito commented 5 years ago

This has been a recurring issue for the last 30 days and is basically making labtab not realiable at all when it comes to making videos

References:

https://github.com/wizbots/wizbots/issues/2601 https://github.com/wizbots/wizbots/issues/2599 https://github.com/wizbots/wizbots/issues/2598 https://github.com/wizbots/wizbots/issues/2597

Bogdan did some reasearching and is basically because we have projects without creators. The following file shows the number of projects with creators and those without any

-.txt

We have changed the API endpoint to do some validation but still, labtab should not allow creation of videos without creators.

Also, we noticed that if we try to create a project and server returns 403 nothing is shown in the labtab. Please handle 403 and any other correctly in labtab.

kapoorutd commented 5 years ago

@internetmosquito Hope you are doing well...

We have try to reproduce the "projects without creators" issue but it is working fine at our end. We already have check on creator field in the application that it can't be Null. Can you please share the steps to reproduce for this issue, so we can verify the same. Also i am unable to access above mentioned reference links as it is giving me "page no found" error.

Please do the needful so that we can fix the issue.

internetmosquito commented 5 years ago

@kapoorutd this is partially resolved on the backend but still reproducable

It doesn't happen with every single program, in staging you can test with this program

https://test.wizbots.com/admin/programs/details/5907c2930d12a9151bb738fc

For mentor Chanel (you should have credentials for it), try to make a video for Tyler Ly student

In any case, basically the problem is that you need to control 40X responses from server when trying to POST a new video and show a message when something wrong happens

Also, consider using Circuit breaker for all your calls to Wizbots please, will make a different ticket for this

https://github.com/Netflix/Hystrix/wiki/How-it-Works#CircuitBreaker